Need someone to look over this code for me

Post

Posted
Rating:
#1 (In Topic #971)
AndyGable
Enthusiast
AndyGable is in the usergroup ‘Enthusiast’
Hi Everyone

I could do with a new pair of eyes going over this code for me to see where i have gone wrong as I can not seem to find it

First of I am using this to add item(s) to the DataGridView

Code (gambas)

  1.     Dim iInd As Integer = 0
  2.     Dim ItemToadd As String
  3.     Dim ItemToadd1 As String
  4.     Dim ItemFound As Integer = 0
  5.        
  6.     ItemToAdd = "Pepsi Max Lime 500ml"
  7.     ItemToadd1 = "£1.80"
  8.    
  9.     ListCurrentSale.Add(ListCurrentSale.Count, String.Padright(ItemToadd, 65) & String.PadLeft(ItemToadd1, 10))
  10.    
  11.     'Find Item in Grid
  12.     For iInd = 0 To ProductGrid.Rows.Count - 1 ' Loop thoug the Product groop and add the offer codes to it
  13.         If ProductGrid[iInd, 1].Text = "4060800306982" Then
  14.             ItemFound = 1
  15.         Else
  16.             ItemFound = 0
  17.         Endif
  18.     Next
  19.  
  20.     If iInd > 0 Then
  21.         iInd = iInd - 1
  22.     Else
  23.         iInd = 0
  24.     End If
  25.    
  26.  
  27.     If ItemFound = 0 Then
  28.         ProductGrid.Rows.Count += 1
  29.         ProductGrid[ProductGrid.Rows.Count - 1, 1].Text = "4060800306982"
  30.         ProductGrid[ProductGrid.Rows.Count - 1, 2].Text = 1
  31.         ProductGrid[ProductGrid.Rows.Count - 1, 3].Text = 180
  32.     Else
  33.         ProductGrid[iInd, 2].Text = (CInt(ProductGrid[iInd, 2].Text) + 1)
  34.         ProductGrid[iInd, 3].Text = (CInt(ProductGrid[iInd, 3].Text) + 180)
  35.     End If
  36.  

and it works fine but if I add another item and then try to add the item again it does not update the existing row it adds a new row

Exanple say I have

4060800306982 2 360

then add

404010011 1 189

and then add another 4060800306982 in stead of showing

4060800306982 3 540

it shows

4060800306982 1 180

<IMG src="https://www.algpos.co.uk/webimage/MSOfferTable_0.png"> </IMG>

second Error I seem to get is when i press my "Total" key It calls SubTotalFunction and it works if I have the correct number in the System but it does not work if i have say 3 (example the Pepsi Offer 4060800306982 is 2 for £2.50 so If I had 3 in the scanned Qty field it errors out

<IMG src="https://www.algpos.co.uk/webimage/MSOfferTable_1.png"> </IMG>
<IMG src="https://www.algpos.co.uk/webimage/MSOfferTable_2.png"> </IMG>
this shows how the Promotions should work

If anyone has any recommendations as well as any whys to fix the code and improve it I am all Ears (as we say in the UK)

I have attached the Full Zip of the Mutilsaver project I am working on (I am still using 3.15.2)

Code (gambas)

  1. ' Gambas module file
  2.  
  3. Public Sub SubTotalFunction()
  4.  
  5.     Dim SubTotal As Integer = 0
  6.     Dim iInd As Integer = 0
  7.  
  8.     'get the total from the Product grid (grid1)
  9.     If FMain.ProductGrid.Rows.Count > 0 Then
  10.         For iInd = 0 To FMain.ProductGrid.Rows.Count - 1
  11.             'Dim TempStore As Integer =
  12.              SubTotal += CInteger(FMain.ProductGrid[iInd, 3].Text)
  13.         Next
  14.         Dim TotalToShow As String = Format((SubTotal / 100), "£0.00")
  15.        
  16.        
  17.         FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, "")
  18.         FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, String.Padright(" SUB TOTAL", 65) & String.PadLeft(TotalToShow, 10))
  19.         FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, String(75, "-"))
  20.        
  21.         ProcessOffers
  22.        
  23.     '   AddMSListTOscreen(SubTotal)
  24.     End If
  26.  
  27.  
  28. Private Sub ProcessOffers()
  29.           Dim iInd As Integer = 0
  30.     Dim ScannedQty As Integer = 0
  31.       Dim OfferQty As Integer = 0
  32.  
  33.     Dim ProductGot As Integer = 0
  34.     Dim OfferValue As Integer = 0
  35.     Dim OfferTotal As Integer = 0
  36.  
  37.  
  38.     For iInd = 0 To FMain.ProductGrid.Rows.Count - 1 ' Loop thoug the Product groop and add the offer codes to it
  39.         Select Case FMain.ProductGrid[iInd, 1].Text
  40.             Case "4060800306982"
  41.                 FMain.ProductGrid[iInd, 0].Text = "00001"
  42.            
  43.             Case "404010011"
  44.                 FMain.ProductGrid[iInd, 0].Text = "00002"
  45.  
  46.             Case "404010022"
  47.                 FMain.ProductGrid[iInd, 0].Text = "00002"
  48.         End Select
  49.     Next
  50.    
  51.     AddAllScannedItemsTogether
  52.  
  53.     'apply offer
  54.     For iInd = 0 To FMain.OfferGrid.Rows.Count - 1 '
  55.         ' This will loop though the Scanned products and work out the Got value for each Item
  56.         If FMain.ProductGrid.Rows.Count = 1 Then
  57.             If FMain.ProductGrid[0, 0].Text = FMain.OfferGrid[iInd, 0].Text Then
  58.                 ScannedQty = CInt(FMain.ProductGrid[0, 2].Text)
  59.                   OfferQty = CInt(FMain.OfferGrid[iInd, 2].Text)
  60.                 FMain.OfferGrid[iInd, 4].Text = Format((ScannedQty / OfferQty), "0")
  61.                 ProductGot = CInt(FMain.OfferGrid[iInd, 4].Text)
  62.                 OfferValue = CInt(FMain.OfferGrid[iInd, 3].Text)
  63.                 OfferTotal = (ProductGot * OfferValue)
  64.                 FMain.OfferGrid[iInd, 6].Text = OfferTotal
  65.             End If
  66.         Else
  67.             If FMain.ProductGrid[iInd, 0].Text = FMain.OfferGrid[iInd, 0].Text Then
  68.                 ScannedQty = CInt(FMain.OfferGrid[iInd, 5].Text)
  69.                   OfferQty = CInt(FMain.OfferGrid[iInd, 2].Text)
  70.                 FMain.OfferGrid[iInd, 4].Text = Format((ScannedQty / OfferQty), "0")
  71.                 ProductGot = CInt(FMain.OfferGrid[iInd, 4].Text)
  72.                 OfferValue = CInt(FMain.OfferGrid[iInd, 3].Text)
  73.                 OfferTotal = (ProductGot * OfferValue)
  74.                 FMain.OfferGrid[iInd, 6].Text = OfferTotal
  75.             End If
  76.         End If
  77.     Next
  79.  
  80. Private Sub AddAllScannedItemsTogether()
  81.     Dim iInd As Integer = 0
  82.     Dim iLoc As Integer = 0
  83.    
  84.     Dim ScannedQty As Integer = 0
  85.       Dim OfferQty As Integer = 0
  86.    
  87.    
  88.     ' Add all items togther to make a summary
  89.     For iInd = 0 To FMain.ProductGrid.Rows.Count - 1 ' Loop thoug the Product groop and add the offer codes to it
  90.         If FMain.ProductGrid[iInd, 0].Text = FMain.OfferGrid[iInd, 0].Text Then
  91.             iLoc = 0
  92.             If FMain.OfferGrid[iInd, 5].Text = "" Then ' Add New Value the table
  93.                 FMain.OfferGrid[iInd, 5].Text = FMain.ProductGrid[iLoc, 2].Text
  94.                 iInd = 0
  95.             Else
  96.                  ScannedQty = CInt(FMain.OfferGrid[iInd, 5].Text)
  97.                 ScannedQty += CInt(FMain.ProductGrid[0, 2].Text)
  98.                 FMain.OfferGrid[iInd, 5].Text = ScannedQty
  99.             End If
  100.         End If
  101.     Next
  102.  
  103.    
  105.  
  106.  
  107.  
  108. Private Sub AddMSListTOscreen(TotalDue As Integer)
  109.     Dim iInd As Integer = 0
  110.     Dim TotalToShow As String
  111.     Dim NewSubTotal As Integer = TotalDue
  112.  
  113.     FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, "  Mutilsavers")
  114.     FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, "  -----------")
  115.  
  116.     For iInd = 0 To FMain.OfferGrid.Rows.Count - 1 ' Loop thoug the Promtion table and show all offers to the PoS
  117.         If FMain.OfferGrid[iInd, 4].Text <> "" Then ' A offer has been processed here
  118.             If CInt(FMain.OfferGrid[iInd, 4].Text) = 1 Then
  119.                 TotalToShow = Format(CInt(FMain.OfferGrid[iInd, 6].Text) / 100, "£0.00")
  120.                 FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, String.Padright(FMain.OfferGrid[iInd, 1].Text, 65) & String.PadLeft(TotalToShow, 10))
  121.             Else
  122.                 Dim QtyOfferBrack As String = Null
  123.                 Dim OfferValue As String = Format(CInt(FMain.OfferGrid[iInd, 3].Text) / 100, "£0.00")
  124.                 TotalToShow = Format(CInt(FMain.OfferGrid[iInd, 6].Text) / 100, "£0.00")
  125.  
  126.                 QtyOfferBrack = "      " & FMain.OfferGrid[iInd, 4].Text & " @ " & OfferValue
  127.                 FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, FMain.OfferGrid[iInd, 1].Text)
  128.                 FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, String.Padright(QtyOfferBrack, 65) & String.PadLeft(TotalToShow, 10))
  129.             End If
  130.            
  131.             NewSubTotal -= (CInt(FMain.OfferGrid[iInd, 5].Text))
  132.         End If
  133.     Next
  134.         TotalToShow = Format(NewSubTotal / 100, "£0.00")
  135.         FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, String(75, "-"))
  136.         FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, String.Padright(" TOTAL TO PAY", 65) & String.PadLeft(TotalToShow, 10))
  137.  
  139.  

Attachment

Mulktisaver Test application to work out the kinks before adding the code to the Main Program.

Online now: No Back to the top

Post

Posted
Rating:
#2
BruceSteers
Guru
BruceSteers is in the usergroup ‘Guru’
Line 82

Code (gambas)

  1. For iInd = 0 To ProductGrid.Rows.Count - 1 ' Loop thoug the Product groop and add the offer codes to it
  2.     If ProductGrid[iInd, 1].Text = "4060800306982" Then
  3.         ItemFound = 1
  4.     Else
  5.         ItemFound = 0
  6.     Endif
  8.  

it checks if found and makes ItemFound = true.
Then it goes on to check the next item and makes ItemFound = False again.
You should break the loop if found like this..

Code (gambas)

  1.  
  2.     For iInd = 0 To ProductGrid.Rows.Count - 1 ' Loop thoug the Product groop and add the offer codes to it
  3.         If ProductGrid[iInd, 1].Text = "4060800306982" Then
  4.             ItemFound = 1
  5.             Break
  6.         Endif
  7.     Next
  8.  

Then iInd should be correct and not need decrementing.
Online now: No Back to the top

Post

Posted
Rating:
#3
BruceSteers
Guru
BruceSteers is in the usergroup ‘Guru’
error in Private Sub AddAllScannedItemsTogether()
 
  For iInd = 0 To FMain.ProductGrid.Rows.Count - 1 ' Loop thoug the Product groop and add the offer codes to it
then…
     If FMain.ProductGrid[iInd, 0].Text = FMain.OfferGrid[iInd, 0].Text Then

If OfferGrid has less items than ProductGrid then it's going to error checking the iInd count
you should also for loop through the OfferGrid with another index var. (i used iInd2)

Like this…   

Code (gambas)

  1. Private Sub AddAllScannedItemsTogether()
  2.  
  3.     Dim iInd As Integer = 0
  4.     Dim iLoc As Integer = 0
  5.  
  6.     Dim ScannedQty As Integer = 0
  7.     Dim OfferQty As Integer = 0
  8.  
  9.     ' Add all items together to make a summary
  10.     For iInd = 0 To FMain.ProductGrid.Rows.Max ' Loop through the Product group and add the offer codes to it
  11.         For iInd2 As Integer = 0 To FMain.OfferGrid.Rows.Max ' Loop through the Offer group and add the offer codes to it
  12.             If FMain.ProductGrid[iInd, 0].Text = FMain.OfferGrid[iInd2, 0].Text Then
  13.                 iLoc = 0
  14.                 If Not FMain.OfferGrid[iInd2, 5].Text Then ' Add New Value the table
  15.                     FMain.OfferGrid[iInd2, 5].Text = FMain.ProductGrid[iLoc, 2].Text
  16.                     iInd = 0
  17.                 Else
  18.                     ScannedQty = CInt(FMain.OfferGrid[iInd2, 5].Text)
  19.                     ScannedQty += CInt(FMain.ProductGrid[0, 2].Text)
  20.                     FMain.OfferGrid[iInd2, 5].Text = ScannedQty
  21.                 End If
  22.             End If
  23.         Next
  24.     Next
  25.  
  27.  
  28.  

Pedantic notes.. ;)
Rows.Max in the same as Rows.Count - 1
No need to write Dim iInt As Integer = 0  by default they already equal 0 so just Dim iInt As Intger does the job
If SomeText = "" , code is faster to write If Not SomeText
Online now: No Back to the top

Post

Posted
Rating:
#4
AndyGable
Enthusiast
AndyGable is in the usergroup ‘Enthusiast’
Hi Bruce

Thanks so much for spotting the errors I have made

I now have a strange one

When add 2 of the Beans and 2 of the Sausages for some reason when I press the total key it add a 3rd offer


<IMG src="https://www.algpos.co.uk/webimage/Heniz_4.png"> </IMG>


This is the update Promotional code I have now

Code (gambas)

  1. ' Gambas module file
  2.  
  3. Public Sub SubTotalFunction()
  4.  
  5.     Dim SubTotal As Integer = 0
  6.     Dim iInd As Integer = 0
  7.  
  8.     'get the total from the Product grid (grid1)
  9.     If FMain.ProductGrid.Rows.Count > 0 Then
  10.         For iInd = 0 To FMain.ProductGrid.Rows.Count - 1
  11.             'Dim TempStore As Integer =
  12.              SubTotal += CInteger(FMain.ProductGrid[iInd, 3].Text)
  13.         Next
  14.         Dim TotalToShow As String = Format((SubTotal / 100), "£0.00")
  15.        
  16.        
  17.         FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, "")
  18.         FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, String.Padright(" SUB TOTAL", 65) & String.PadLeft(TotalToShow, 10))
  19.         FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, String(75, "-"))
  20.        
  21.         ProcessOffers
  22.        
  23.       AddMSListTOscreen(SubTotal)
  24.     End If
  26.  
  27.  
  28. Private Sub ProcessOffers()
  29.           Dim iInd As Integer = 0
  30.     Dim ScannedQty As Integer = 0
  31.       Dim OfferQty As Integer = 0
  32.  
  33.       Dim TotalQty As Integer = 0
  34.     Dim OfferValue As Integer = 0
  35.     Dim OfferTotal As Integer = 0
  36.  
  37.  
  38.     For iInd = 0 To FMain.ProductGrid.Rows.Count - 1 ' Loop thoug the Product groop and add the offer codes to it
  39.         Select Case FMain.ProductGrid[iInd, 1].Text
  40.             Case "4060800306982"
  41.                 FMain.ProductGrid[iInd, 0].Text = "00001"
  42.            
  43.             Case "404010011"
  44.                 FMain.ProductGrid[iInd, 0].Text = "00002"
  45.  
  46.             Case "404010012"
  47.                 FMain.ProductGrid[iInd, 0].Text = "00002"
  48.         End Select
  49.     Next
  50.    
  51.     AddAllOffersTogether
  52.    
  53.     'apply offer
  54.     For iInd = 0 To FMain.OfferGrid.Rows.Count - 1 '
  55.         ' This will loop though the Scanned products and work out the Got value for each Item
  56.         If FMain.ProductGrid.Rows.Count = 1 Then
  57.             If FMain.ProductGrid[0, 0].Text = FMain.OfferGrid[iInd, 0].Text Then
  58.                 ScannedQty = CInt(FMain.OfferGrid[iInd, 5].Text)
  59.                   OfferQty = CInt(FMain.OfferGrid[iInd, 2].Text)
  60.                 FMain.OfferGrid[iInd, 4].Text = Format((ScannedQty / OfferQty), "0")
  61.                   TotalQty = CInt(FMain.OfferGrid[iInd, 4].Text)
  62.                 OfferValue = CInt(FMain.OfferGrid[iInd, 3].Text)
  63.                 OfferTotal = (TotalQty * OfferValue)
  64.                 FMain.OfferGrid[iInd, 6].Text = OfferTotal
  65.             End If
  66.         Else
  67.             If FMain.ProductGrid[iInd, 0].Text = FMain.OfferGrid[iInd, 0].Text Then
  68.                 ScannedQty = CInt(FMain.OfferGrid[iInd, 5].Text)
  69.                   OfferQty = CInt(FMain.OfferGrid[iInd, 2].Text)
  70.                 FMain.OfferGrid[iInd, 4].Text = Format((ScannedQty / OfferQty), "0")
  71.                   TotalQty = CInt(FMain.OfferGrid[iInd, 4].Text)
  72.                 OfferValue = CInt(FMain.OfferGrid[iInd, 3].Text)
  73.                 OfferTotal = (TotalQty * OfferValue)
  74.                 FMain.OfferGrid[iInd, 6].Text = OfferTotal
  75.             End If
  76.         End If
  77.     Next
  79.  
  80.  
  81. Private Sub AddMSListToScreen(TotalDue As Integer)
  82.     Dim iInd As Integer = 0
  83.     Dim TotalToShow As String
  84.     Dim NewSubTotal As Integer = TotalDue
  85.  
  86.     FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, "  Mutilsavers")
  87.     FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, "  -----------")
  88.  
  89.     For iInd = 0 To FMain.OfferGrid.Rows.Count - 1 ' Loop thoug the Promtion table and show all offers to the PoS
  90.         If FMain.OfferGrid[iInd, 4].Text <> "" Then ' A offer has been processed here
  91.             If CInt(FMain.OfferGrid[iInd, 4].Text) = 1 Then
  92.                 TotalToShow = Format(CInt(FMain.OfferGrid[iInd, 6].Text) / 100, "£0.00")
  93.                 FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, String.Padright(FMain.OfferGrid[iInd, 1].Text, 65) & String.PadLeft("-" & TotalToShow, 10))
  94.             Else
  95.                 Dim QtyOfferBrack As String = Null
  96.                 Dim OfferValue As String = Format(CInt(FMain.OfferGrid[iInd, 3].Text) / 100, "£0.00")
  97.                 TotalToShow = Format(CInt(FMain.OfferGrid[iInd, 6].Text) / 100, "£0.00")
  98.  
  99.                 QtyOfferBrack = "      " & FMain.OfferGrid[iInd, 4].Text & " @ " & OfferValue
  100.                 FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, FMain.OfferGrid[iInd, 1].Text)
  101.                 FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, String.Padright(QtyOfferBrack, 65) & String.PadLeft("-" & TotalToShow, 10))
  102.             End If
  103.            
  104.             NewSubTotal -= (CInt(FMain.OfferGrid[iInd, 6].Text))
  105.         End If
  106.     Next
  107.         TotalToShow = Format(NewSubTotal / 100, "£0.00")
  108.         FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, String(75, "-"))
  109.         FMain.ListCurrentSale.Add(FMain.ListCurrentSale.Count, String.Padright(" TOTAL TO PAY", 65) & String.PadLeft(TotalToShow, 10))
  110.  
  112.  
  113. Private Sub AddAllOffersTogether()
  114.  
  115.     Dim iInd As Integer = 0
  116.     Dim iLoc As Integer = 0
  117.  
  118.     Dim ScannedQty As Integer = 0
  119.     Dim OfferQty As Integer = 0
  120.  
  121.     ' Add all items together to make a summary
  122.     For iInd = 0 To FMain.ProductGrid.Rows.Max ' Loop through the Product group and add the offer codes to it
  123.         For iInd2 As Integer = 0 To FMain.OfferGrid.Rows.Max ' Loop through the Offer group and add the offer codes to it
  124.             If FMain.ProductGrid[iInd, 0].Text = FMain.OfferGrid[iInd2, 0].Text Then
  125.                 iLoc = 0
  126.                 If Not FMain.OfferGrid[iInd2, 5].Text Then ' Add New Value the table
  127.                     FMain.OfferGrid[iInd2, 5].Text = FMain.ProductGrid[iLoc, 2].Text
  128.                     iInd = 0
  129.                 Else
  130.                     ScannedQty = CInt(FMain.OfferGrid[iInd2, 5].Text)
  131.                     ScannedQty += CInt(FMain.ProductGrid[0, 2].Text)
  132.                     FMain.OfferGrid[iInd2, 5].Text = ScannedQty
  133.                 End If
  134.             End If
  135.         Next
  136.     Next
  138.  
Online now: No Back to the top
1 guest and 0 members have just viewed this.